src/sbbs3 useredit.cpp 1.68 1.69
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14500

Modified Files:
useredit.cpp
Log Message:
Cruft removal.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/276a4a5b2409ed199eb333a2
Modified Files:
src/sbbs3/useredit.cpp
Log Message:
Allow left/right/home/key keys to navigate users in online "UEDIT"
- as requested (and insured) by Nelgin

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/53e44f9b6c291691811fde16
Modified Files:
src/sbbs3/useredit.cpp
Log Message:
Don't prompt UTF-8 terminal users to ask if they support CP437.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/98d4f0839217108314a838d5
Modified Files:
src/sbbs3/useredit.cpp
Log Message:
Allow forward-to-netmail option to be toggled off by user

Bug introduced in commit a2f5990b4db (Sept-11):
By calling putuserrec() before modifying user->misc and then calling
noyes(), we're giving an opportunity for the low-level node sync code to
read the modified "useron" back from the database, thus losing the change
we just made to user->misc. Instead, move the putuserrec() call to the end
of the case statement. Another option would have been to turn off the NETMAIL flag before the first call to putuserrec().

Bug reported by Nugax (BYTEXCHG)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/583ab9195d04961c697a10cd
Modified Files:
src/sbbs3/useredit.cpp
Log Message:
Always reload the edited user record from disk after executing a "usercfg_mod"

Normally, when modifying user fields via JS, the "user modified" node.dab
flag would be set for that user (on all node's that user is logged-into) and the user record automatically re-read (soon after). But this doesn't work during newuser registration because the user is not yet "logged-into" a node.

This fixes the issue reported by Nelgin (and observed on amessyroom's BBS) whereby if a new user resets/changes their external message editor, it would not take effect for their new user validation email to the sysop (they would still be using the default new user message editor as configured by the
sysop).

It's possible other new user default changes made (e.g. language) would also not have taken immediate effect as a result of this bug (now fixed).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/207546a2b6e2ce0852852cda
Modified Files:
src/sbbs3/useredit.cpp
Log Message:
openuserdat() was recently changed to not always return -1 on error

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f7c75dee778e0383c550e0bd
Modified Files:
src/sbbs3/useredit.cpp
Log Message:
Populate the security level string being edited with current level (number)

This appears to have been the original intention (otherwise, why call ultoa?), but was never done. Just a usability/convenience thing, but an apparent bug.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e71c279c5f4f0eaf0310bdf8
Modified Files:
src/sbbs3/useredit.cpp
Log Message:
Elminate meaningless typecast

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net