1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/smblib/smblib.c

    From rswindell@VERT to CVS commit on Saturday, April 04, 2020 14:11:36
    src/smblib smblib.c 1.205 1.206
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smblib.c
    Log Message:
    Include more details in "illegal header length increase" error msg.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, April 14, 2020 00:22:54
    src/smblib smblib.c 1.206 1.207
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv6132

    Modified Files:
    smblib.c
    Log Message:
    On Windows, smb_addmsg() was slow because smb_updatethread() was slow:

    So on Windows, calling unlock() on a file region that you don't have locked, incurs a delay. Likewise, calling lock() on a file region that already have locked incurs a delay. These delays were seriously throttling message imports on Windows (e.g. importing echomail or QWK packets). What should take a few seconds, was taking minutes with noticeable delays. This code has been performing redundant locks/unlocks for over 15 years, so I can only conclude that the performance penalty is a new behavior introduced in recent version(s) of Windows.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, April 14, 2020 00:50:32
    src/smblib smblib.c 1.207 1.208
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv11249

    Modified Files:
    smblib.c
    Log Message:
    Some very old, yet inconsistent, behavior of smb_hfield_add() could pretty easily result in a message body being added to a message base with no accompanying message header: if the header data was 0-length, the hfield_dat was not actually allocated and the applicable smbmsg_t convenience pointer was not set accordingly. This had the side effect that if a message were to be imported with a blank recipient ("To" field), the header was not created at
    all (to support mutliple header, single body msgs, i.e. bulkmail).
    The other functions that set the convenience pointers do not treat 0-length header field data special, so this was inconsistent behavior.
    Most message types (e.g. networks) don't want 0-length "to" fields, but that shoudl be enforced somewhere else, not here.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, September 13, 2024 20:08:11
    https://gitlab.synchro.net/main/sbbs/-/commit/1ab4ef2bfe0d0b1c7598cc53
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    smb_getmsgidx() now reads entire index records from file bases too

    chksmb needed this to perform filename checks (index against headers).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, September 13, 2024 20:30:10
    https://gitlab.synchro.net/main/sbbs/-/commit/ffa2c51ba23c59641e1a6e47
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    MSVC requires a 0 in the struct initializer

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, November 10, 2024 16:14:22
    https://gitlab.synchro.net/main/sbbs/-/commit/6224ce6476a079f5e1e7a880
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    Fix printf formatting issue in error message

    GCC and Coverity (x 2) both flagged this one.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net