• src/sbbs3/postmsg.cpp

    From rswindell@VERT to CVS commit on Sunday, September 01, 2019 20:54:18
    src/sbbs3 postmsg.cpp 1.127 1.128
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26458

    Modified Files:
    postmsg.cpp
    Log Message:
    Don't create the security-related header fields if the assocated "client" object/struct doesn't have any meaningful data. Prevent this from happening:
    SenderTime 19700101000000Z
    SenderIpAddr
    SenderHostName
    SenderPort 0



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, September 01, 2019 21:42:14
    src/sbbs3 postmsg.cpp 1.128 1.129
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2344

    Modified Files:
    postmsg.cpp
    Log Message:
    Automatic UTF-8 header field detection in savemsg(): if the to, from, or subject header fields are non-ASCII yet valid UTF-8, set the auxattr flag indicating that the msg header is in UTF-8.
    This function is used by JS MsgBase.save_msg(), so any scripts/services that use it (e.g. nntpservice, newslink, imapservice, etc.) to save messages with header fields that may be UTF-8 encoded will automatically benefit from this detection. Mixing CP437 (the default) with UTF-8 encoded header fields is not supported, so if one header field is valid UTF-8 (not plain US-ASCII), then they had better all be either plain US-ASCII or UTF-8 or there will be
    UTF-8 decoding issues when attempting to display or convert later.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wednesday, April 22, 2020 22:25:08
    src/sbbs3 postmsg.cpp 1.131 1.132
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26315

    Modified Files:
    postmsg.cpp
    Log Message:
    Don't try to signal an empty semaphore path if the netmail_sem is blank.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, September 30, 2020 20:25:17
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/97bade44ebad5b431485e93c
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Notify local recipients of locally-posted messages addressed to them.

    While SBBSecho would notify local users of imported messages addressed to
    them (both EchoMail and NetMail) and QWK-imported messages recently gained
    the ability to notify local recipients of messages addressed to them, other methods of posting messages (e.g. just using the normal terminal server
    method, e.g. the 'P' command) or using any JavaScript (e.g. web) methods of posting messages lacked recipient notifications. So that's now fixed.
    And for JavaScript-saved local email messages too. I don't *think* this will result in any duplicate notifications of received messages, but let me know
    if you see excess/duplicate notifications.
    Anonymously posted messages are excluded.
    Messages posted to yourself are excluded (who does that?).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, September 30, 2020 20:26:58
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/f4ac7f3920abba7d3c717e3d
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Resolve a gcc warning about signedness.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Saturday, October 03, 2020 11:16:52
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/c8193766c6b75abb18a2c257
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Fix savemsg() bug introduced in 97bade44eb (Sep-30), returning false failure

    'i' is the return value of savemg(), used to determine success or failure
    (and what kind of failure) - so we can't use that for the usernumber of
    the recipient.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, December 09, 2024 19:15:31
    https://gitlab.synchro.net/main/sbbs/-/commit/69111a8f420d212de3c0d638
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    If user doesn't modify the replied-to-msg subject, use the original subject

    (which might be UTF-8 encoded). This works-around the problem that Accession reported in #synchronet with my reply to a UTF-8 encoded message using a CP437 terminal which resulted in a message body that was UTF-8 encoded but a message subject that was CP437 encoded. This mix of encodings is not supported by FTN standards.

    This is just a work-around since if the user modifies the subject the result could still have the CP437 unside-down question marks (indicating non-translatable UNICODE chars) and those should be converted to UTF-8
    chars when going out on FTN or being stored in the message base. So there's still a bug here somewhere that I need to look into more.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, January 05, 2025 21:06:01
    https://gitlab.synchro.net/main/sbbs/-/commit/1dde501fe8ea8dc8bea5e3d4
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Call add_msg_id() *after* opening the message base to send notification email

    notify() was creating wrongly-formated auto-generated Message-IDs:
    e.g. Message-ID: <677B3F17.0.notices@vert.synchro.net>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net