https://gitlab.synchro.net/main/sbbs/-/commit/e15ba30749ace18e46675ec4
Modified Files:
src/syncterm/ssh.c
Log Message:
Move ssh_complete out of ssh_mutex

Coverity seems to hate it mostly in the mutex, so change it to
mostly outside of the mutex and see if that's fine.

It doesn't really matter where it's changed as it's an atomic bool.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1326b624bd973b8e3f6e9b93
Modified Files:
src/syncterm/ssh.c
Log Message:
Fix memory leak when connection lost during SFTP key check

Found by scan-build

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ee15f3cfe79bf6f5f0486f3e
Modified Files:
src/syncterm/ssh.c
Log Message:
Remove more redundant code

ssh_active was never set to false anymore
channel_gone did exactly the same thing as conn_api.terminate
change read/write timeouts to zero when closing

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ad896e3b34767ba64207875
Modified Files:
src/syncterm/ssh.c
Log Message:
Remove likely obsolete Coverity suppression.

It can be added back if the issue reappears.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/772609493c77c12dcadf8bc4
Modified Files:
src/syncterm/ssh.c
Log Message:
assert() ssh globals are initialized correctly.

Some weren't (mostly sftp ones though)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ff6b5ecb393dcf2f170f68e
Modified Files:
src/syncterm/ssh.c
Log Message:
Re-add coverity suppression. Not obsolete.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/062c3faba40c1a72664e80c3
Modified Files:
src/syncterm/ssh.c
Log Message:
Call ssh_close() on failure after ssh_session is initialized

Fixes assertion on failed connects.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a45466867429f3ad7043fb5e
Modified Files:
src/syncterm/ssh.c
Log Message:
Add missing NULL checks on malloc() in ssh_connect()

conn_api.rd_buf and conn_api.wr_buf were allocated with malloc() but
never checked for failure. The I/O threads started immediately after
would dereference the NULL pointers and crash. Other connection types (conn_pty.c, conn_conpty.c, modem.c, rlogin.c) already had these
checks; ssh.c was an oversight.

The error paths also free(pubkey), which is either a valid allocation
from get_public_key() or the initial NULL Ä both safe for free().

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0d4a52ec4893ef1cb472f45f
Modified Files:
src/syncterm/ssh.c
Log Message:
Add missing create_conn_buf() error checks in ssh.c

Check return values and clean up on failure, matching the pattern
used by all other connection providers (rlogin, telnet, modem, pty,
conpty).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net