https://gitlab.synchro.net/main/sbbs/-/commit/9c3a122c0a6fa522d91807c4
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
Fix another Coverity defect

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7a7caa110f6693d15ee2e611
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
Fix MSVC warning about signed/unsigned comparison

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d513362bbc8619e98695e333
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
If editor doesn't create a file, just return false from sbbs_t::editfile()

... don't log any error message.

This fixes issue #914

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9abbcf31c3e92cc111f9189c
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
Display changed attributes in change msg attribute function

This appears to have been broken since commit 556225fa7 (4 years ago, addressing a Coverity complaint <sigh>).

When changing (toggling) the attributes of a message, the new/changed attributes were supposed to be shown, but were not. Exiting did save those attributes correctly, but the UI was very non-intuitive because of this bug.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a7106cca0cf813beb39710d0
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
writemsg: bail out on ftell error before reusing offset (CID 640333)

writemsg() captures the message-start offset with ftell() and reuses
it via three subsequent fseek(stream, l, SEEK_SET) calls. ftell may
return -1 on error, in which case the fseek calls would seek to a
negative offset (UB) and corrupt the quoted-text buffer. Bail out
cleanly instead, mirroring the existing error-cleanup paths.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fcffe36822eb49d81f25d7f6
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
writemsg: handle fseek/fexistcase return values (CIDs 486496, 548248)

- writemsg(): two fexistcase() calls are case-fix-only (same pattern
as 76b5c7f43); cast to (void).
- movemsg(): combine fseek+fread error handling so a seek failure
takes the same error-recovery path as a read failure.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8d91e80d1fc5a8f103574ef8
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
writemsg: change l to long so ftell() error check works (CID 645990)

l was declared uint, so the (l < 0) check after l = (long)ftell(stream)
was always false. ftell() returns long and can return -1 on error.
Update the (ulong) casts on the level_linespermsg comparisons accordingly.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net