• src/sbbs3/ftpsrvr.cpp

    From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Tuesday, May 05, 2026 15:55:25
    https://gitlab.synchro.net/main/sbbs/-/commit/8a7ff359a230d7820816acb5
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    Use int (32-bits) instead of bool (8-bits) for setsockopt(... REUSEADDR)

    Fix issue #1137 (bug introduced in commit f28f210b)
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Tuesday, May 05, 2026 15:56:57
    https://gitlab.synchro.net/main/sbbs/-/commit/f1f4ac3fce5a360a4f2446ed
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    Use int (32-bit) instead of bool (8-bit) for setsockopt(... NODELAY)

    Similar to fix for issue #1137
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Wednesday, May 06, 2026 22:36:57
    https://gitlab.synchro.net/main/sbbs/-/commit/769599ebba788f26253334f3
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    ftpsrvr: handle return values in send/receive_thread and sock_recvbyte (CIDs 643130, 643142, 643143)

    - send_thread/receive_thread: log a warning if fseeko to xfer.filepos
    fails so a seek error is no longer silent (downstream I/O would
    proceed at the wrong offset). Continues into the transfer loop
    either way to preserve existing behavior.
    - sock_recvbyte: cast the inner cryptSetAttribute (re-arming the read
    timeout) to void; this is best-effort and the matching call above
    it is already error-checked.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Thursday, May 21, 2026 20:23:05
    https://gitlab.synchro.net/main/sbbs/-/commit/308b735e39c6aaefec799fd0
    Modified Files:
    src/sbbs3/ftpsrvr.cpp
    Log Message:
    ftpsrvr: remove duplicate ndx temp-file fopen() from de-dup commit

    Commit 19c826410 ("add errprintf() and route LOG_ERR/LOG_CRIT through it
    for de-dup") was meant only to convert the index-file fopen() failure's lprintf(LOG_ERR,...) to errprintf(..., WHERE, ...). A rebase merge
    resolution instead inserted a second, redundant fopen() of the "ndx"
    temp file ahead of "success = true;" (giving the new copy the errprintf)
    while leaving the original lprintf() open untouched.

    That left two opens:
    - the getdate (MDTM-style) path opened a temp file it never uses --
    contradicting the "No temp file needed for a modification-time query"
    comment -- and never set tmpfile/delfile, leaking both the descriptor
    and the temp file (ironic in an EMFILE-motivated change);
    - the !getdate path opened the file twice, leaking the first descriptor.

    Drop the spurious block and keep the de-dup conversion on the surviving
    open inside the else branch, restoring the original single-open logic.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)